Skip to content

Ensure that explicitly provided heading conversion functions are used (#212) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chrispy-snps
Copy link
Collaborator

@chrispy-snps chrispy-snps commented Apr 20, 2025

Fixes #212.

The precedence of conversion function lookup is modified so that explicitly defined heading conversion functions (such as convert_h3()) take precedence over general heading conversion functions (processed by convert_hN()).

Unit tests are added for both cases.

@chrispy-snps chrispy-snps requested a review from AlexVonB April 20, 2025 16:24
@chrispy-snps chrispy-snps changed the title ensure that explicitly provided header conversion functions are used (#212) ensure that explicitly provided heading conversion functions are used (#212) Apr 20, 2025
@chrispy-snps chrispy-snps force-pushed the chrispy/fix-custom-header-conversion-functions branch from e4459d5 to 0aa21e3 Compare April 20, 2025 16:27
@chrispy-snps chrispy-snps changed the title ensure that explicitly provided heading conversion functions are used (#212) Ensure that explicitly provided heading conversion functions are used (#212) Apr 21, 2025
@chrispy-snps chrispy-snps merged commit 016251e into matthewwithanm:develop May 3, 2025
1 check passed
Wuhall pushed a commit to Wuhall/python-markdownify that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom converter functions are not recognized for heading tags
1 participant